Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icons for dark theme #37

Closed
Cqoicebordel opened this issue Feb 6, 2019 · 7 comments
Closed

Add icons for dark theme #37

Cqoicebordel opened this issue Feb 6, 2019 · 7 comments
Milestone

Comments

@Cqoicebordel
Copy link

In a dark theme (breeze-dark here) the icons are barely visible. An image is worth a thousand words :
image

@DamirPorobic
Copy link
Member

I do had a plan to add light color icons, but had no time yet. Valid feature request.

@DamirPorobic DamirPorobic added this to the 0.0.2 milestone Feb 6, 2019
@Cqoicebordel
Copy link
Author

Note that :

  • Ksnip is also affected (just in case you didn't notice)
  • Since all icons are SVG and in a single color, it might be possible to change the color dynamically depending on the theme, either through modification of the SVG itself (by populating the colors dynamically), or through CSS.

@DamirPorobic
Copy link
Member

Yes, I'm aware of it. I will probably create a light set of icons and add a loader which checks the theme color and loads the correct icon.

@Cqoicebordel
Copy link
Author

That's what I meant : You don't need another set of icons, you just have to set the fill, and the fill stroke of the SVG, to the OS theme value.
For example, http://cqoicebordel.free.fr/SVGExample/. The color is changed via CSS and nothing else is done (it's twice the SVG present in your repo (a bit cleaned though)).
And you can do that using myPushButton->setStyleSheet("* { fill: blue }");
See http://doc.qt.io/qt-5/stylesheet-syntax.html

@Cqoicebordel
Copy link
Author

(I'm not familiar with the C++ side of Qt, so I might be mistaken, but QStyle could do the same, I think)

@DamirPorobic
Copy link
Member

Might be working, but I had bad experience with QStyleSheets in the past as they could behave differently on different systems, so usually use them as kind of last option. kImageAnnotator should not be the problem, all icons are svg, in ksnip however, some icons are png and I've tried recently to port them to svg but the small ones look blurry due to downscaling. Upscaling looks ok.

@DamirPorobic DamirPorobic changed the title Icon difficult to see in dark theme Add icons for dark theme Feb 9, 2019
@DamirPorobic
Copy link
Member

Added support in ksnip too

@DamirPorobic DamirPorobic modified the milestones: 0.0.2, 0.1.0 Feb 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants