-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add icons for dark theme #37
Comments
I do had a plan to add light color icons, but had no time yet. Valid feature request. |
Note that :
|
Yes, I'm aware of it. I will probably create a light set of icons and add a loader which checks the theme color and loads the correct icon. |
That's what I meant : You don't need another set of icons, you just have to set the fill, and the fill stroke of the SVG, to the OS theme value. |
(I'm not familiar with the C++ side of Qt, so I might be mistaken, but QStyle could do the same, I think) |
Might be working, but I had bad experience with QStyleSheets in the past as they could behave differently on different systems, so usually use them as kind of last option. kImageAnnotator should not be the problem, all icons are svg, in ksnip however, some icons are png and I've tried recently to port them to svg but the small ones look blurry due to downscaling. Upscaling looks ok. |
Added support in ksnip too |
In a dark theme (breeze-dark here) the icons are barely visible. An image is worth a thousand words :
The text was updated successfully, but these errors were encountered: