Allow the ToolPicker to have a scrollbar

[precla]

The ToolPicker is never fully visible when the kImageAnnotator window is smaller than the ToolPicker area.
Occurs especially when used embedded within an program, like Spectacle, which makes it almost
impossible for the user to know if there are more tools to choose from. Instead of going by pure
luck/intuition and resizing the main window, in this example the window of Spectacle, showing a scrollbar
when the window is too small to show all tools by default gives a hint to the user that there are more tools available.
The scroll bar would be only shown when needed, not always :)

How it currently looks within Spectacle:

[DamirPorobic]

@precla thanks for providing this PR, I like the idea but there is a problem, currently you can do something like this:

To have the icons in two columns, I know some users like to have it that ways as it resamples the legacy layout.

Now cannot do that anymore as you see the scrollbar always:

Is there a way to combine both features? Try multiple columns and if you've used up all column space and some icons still hidden then show scrollbar?

(btw I like you console prompt, what are you using? Is that plain zsh?)

[DamirPorobic]

Oh and why is the Spectacle window so small? I thought they have a separate window for annotation? That one seems indeed to be to small for all the controls.

[precla]

First the important thing: console is KDE's Konsole, using oh-my-zsh with USE_POWERLINE="true" and manjaro-zsh-configuration :)

Hm, how to have icons in two columns? Looks like I missed the piece of code that enables that.

And yes, Spectacle keeps the Annotator inside the current Spectacle window, using the current window size of Spectacle.

[DamirPorobic]

First the important thing: console is KDE's Konsole, using oh-my-zsh with USE_POWERLINE="true" and manjaro-zsh-configuration :)

Looking nice, I'll have to try that out.

Hm, how to have icons in two columns? Looks like I missed the piece of code that enables that.

Just resize to the right (in this case but the widget can be positioned on left, right, bottom or top so basically resizing in all direction). It should be trying to got to the right size as far as possible, then switch to next row and so on:

The magic is done by the FlowLayout.cpp class (src/widgets/misc).

[precla]

Thanks, just tried it in Spectacle. Tho, would be nice if there is a function call that would do that, instead of the user having to resize it. Not every user will notice this.

I will take a closer look into this on the weekend when I have more time, maybe we can have both scrollbar and this resize with multiple columns.

[DamirPorobic]

Thanks, just tried it in Spectacle. Tho, would be nice if there is a function call that would do that, instead of the user having to resize it. Not every user will notice this.

Problem is you don't know how far to go, you could always assume to go with two rows but ksnip for example goes with one. Or someone would like four columns and three rows. Tastes are different.

I will take a closer look into this on the weekend when I have more time, maybe we can have both scrollbar and this resize with multiple columns.

That would be lovely. Let me know if you need anything. :)

[precla]

Found the solution:
https://forum.qt.io/post/119409

Applied & tested it, almost as you need it :) . When the Tool Selection widget is resized so that 3x3 icons fit, one icon is missing (the sticker) and there is no scrollbar :s

This one was missing:

https://github.com/ksnip/kImageAnnotator/pull/258/files#diff-2bd0d8bd582468496f4c04a11e3583390064df832bd6125195548f06bfa1082bR29

[DamirPorobic]

Looking odlično :)

Merging it into 0.5.3 so it get's delivered with the next patch. Thanks for providing this enhancement/fix!

[precla]

Looking odlično :)

Merging it into 0.5.3 so it get's delivered with the next patch. Thanks for providing this enhancement/fix!

Zahvaljujem :)

Have you tested it? Because of the weird bug with 3x3 and one icon missing :D

[DamirPorobic]

Have you tested it? Because of the weird bug with 3x3 and one icon missing :D

Yes, I can reproduce it, also with 4x2 when two icons are in the last row but that's ok for now, it's minor issue, at least it's better then it was.

One more think, what do you think of removing the second border? This widget is the only one with two. mScrollareaToolPicker->setFrameShape(QFrame::NoFrame);

[precla]

mScrollareaToolPicker->setFrameShape(QFrame::NoFrame);

Yeah, let's do it. Looks much better :)

[precla]

Added within this MR

[DamirPorobic]

Merged, thanks again for providing the PR :)