Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No "rectangle area" screeshot option in ksnip-1.9.1-continuous-x86_64.AppImage #660

Open
Moltkex opened this issue Jun 1, 2021 · 16 comments

Comments

@Moltkex
Copy link

Moltkex commented Jun 1, 2021

Describe the bug
There is no "rectangle area" screeshot option in ksnip-1.9.1-continuous-x86_64.AppImage

To Reproduce
Steps to reproduce the behavior:

  1. Launch ksnip-1.9.1-continuous-x86_64.AppImage
  2. Click on "New" to expand the menu.
  3. Scroll down and see the option for "rectangle area" is missing.

Expected behavior

  1. Launch ksnip-1.9.1-continuous-x86_64.AppImage
  2. Click on "New" to expand the menu.
  3. Scroll down and see the option for "rectangle area" is available.

Screenshots
ksnip-error.png

By the way, uploading to imgur doesn't work either.

Desktop (please complete the following information):

  • OS: Linux
  • Distribution in case of Linux: KDE Neon(Testing)
  • Window System in case of Linux: Wayland
  • ksnip version 1.9.1(continuos)
  • How did you install ksnip: AppImage
@Moltkex Moltkex added the bug label Jun 1, 2021
@DamirPorobic
Copy link
Member

It's not a bug, Rect Area screenshots are just not supported under Plasma Wayland:
image

That comes from the Wayland restriction, at least when I implemented it it was not possible make it work under Plasma Wayland.

@Moltkex
Copy link
Author

Moltkex commented Jun 1, 2021

It's not a bug, Rect Area screenshots are just not supported under Plasma Wayland:

Thanks for your reply. Ah, yeah, it does work in X. However, spectacle does have the option to capture rectangular areas under Wayland, that's how I took that screenshot. I'm no coder by any means, but since ksnip seems to be heavily inspired on that one, maybe take a look at spectacle's code?

@DamirPorobic
Copy link
Member

ksnip is not inspired at all on Spectacle, we just use the same DBUS calls for Screenshots under KDE Plasma :)

If I remember correctly the KDE folks gave Spectacle some additional permissions to be able to avoid the restrictions that other screenshot tools are getting under KDE Plasma Wayland. But it's been a while since I last time checked, maybe there was some change. I'll have a look.

@DamirPorobic DamirPorobic added this to To do in v1.10.0 via automation Jun 1, 2021
@Moltkex
Copy link
Author

Moltkex commented Jun 1, 2021

ksnip is not inspired at all on Spectacle, we just use the same DBUS calls for Screenshots under KDE Plasma :)

Ah, ok my bad. I thought maybe that could be the case, and I was clearly wrong since I just checked and ksnip(2016) is older than spectacle(2017). They look pretty much alike though; whole annotation tools section looks pretty much the same. Ksnapshot(2011)?

@DamirPorobic
Copy link
Member

Well yeah, the Annotation Section in Spectacle is actually ksnip's Annotator, kImageAnnotator ;)

ksnip was inspired initially by Windows Snipping Tool as I was missing this tool when I switched from Windows to Linux in 2015 or 2016, so I started writing this clone, which is now much more feature rich. I have asked the the KDE folks if they want ksnip in the KDE Framework but they said they have Spectacle and don't need it but were interested in the annotation so I extracted (and basically rewrote) the Annotation Widget as a standalone widget that can be used anywhere, currently it's used in ksnip and Spectacle.

@Moltkex
Copy link
Author

Moltkex commented Jun 1, 2021

Well yeah, the Annotation Section in Spectacle is actually ksnip's Annotator, kImageAnnotator ;)

ksnip was inspired initially by Windows Snipping Tool as I was missing this tool when I switched from Windows to Linux in 2015 or 2016, so I started writing this clone, which is now much more feature rich. I have asked the the KDE folks if they want ksnip in the KDE Framework but they said they have Spectacle and don't need it but were interested in the annotation so I extracted (and basically rewrote) the Annotation Widget as a standalone widget that can be used anywhere, currently it's used in ksnip and Spectacle.

Ah, cool! 👍 Yeah, I like ksnip and been using it for quite some time now. I've advocated for its use and adoption by some distros to be part of the "software compilation" they offer by default in forums and the like. I only asked its "origins" out of curiosity. Thanks for the explanation and for providing such a wonderful piece of software! 😃

@DamirPorobic
Copy link
Member

Glad you like you it :)

And thanks for advocating for ksnip, such individual actions really help make people aware of it ;)

@Moltkex
Copy link
Author

Moltkex commented Jun 2, 2021

Glad you like you it :)

And thanks for advocating for ksnip, such individual actions really help make people aware of it ;)

You're welcome 😃 I try to do the same with those apps I find superb such as ksnip, and that's why I think every distro should adopt it to be the default screenshot tool.

@Xarkam
Copy link

Xarkam commented Jun 15, 2021

Something planned for this functionality under wayland now that kde has advanced wayland support?

@DamirPorobic
Copy link
Member

I have planned to look into it for the next Minor Release (1.10.0) though I don't know what's possible, haven't looked into it yet. I'll try to provide the functionality that Spectacle provides but that heavily depends if the functionality is made available for non KDE applications.

@Xarkam
Copy link

Xarkam commented Jun 15, 2021

I have planned to look into it for the next Minor Release (1.10.0) though I don't know what's possible, haven't looked into it yet. I'll try to provide the functionality that Spectacle provides but that heavily depends if the functionality is made available for non KDE applications.

The rectangular regions and active window are the two features that prevent me from migrating to wayland :)

@questuk
Copy link

questuk commented Aug 19, 2021

I have to agree, Ksnip is my tool of choice !
It would be great if it could do the rectangular area, as I use Ksnip on my KDE - Kubuntu 21.04 system and until I can use rectangular area, I can't switch to Wayland, I may be wrong but I think Wayland is the future ?

Damir Porobic thanks for GREAT software.

@DamirPorobic
Copy link
Member

Wayland is trying to become the future for some while. IMHO he problem that they have is that they place security over everything else, causing usability issues like this one with screenshots or global hotkeys, that again causes people to avoid it because they cannot work with stuff they're used to. Wayland will eventually come but it's not coming as fast as it could.

@DamirPorobic
Copy link
Member

I will definitely look into improving our Wayland support but I'm currently blocked with migrating our CI from Travis-CI to GitHub actions. If anyone is willing to look into this, PRs are welcome.

@thegreyshadow
Copy link

I'm also bitten by this bug. (btw just built 1.9.2 on Slackware and it's great as I came to expect from you).

I can get a screenshot of a certain rectangular area under Wayland using a quite cumbersome procedure:

  1. Get a screenshot using "Window under cursor" or a "Full Screen (All Monitors)" if your area crosses over window boundaries.
  2. Press the "Crop" button.
  3. Crop the image until you get the rectangular area you wish.
  4. Press the "Apply" button.
  5. Now you have a screenshot of a rectangular area.

Damir, maybe it would be possible to automate this workaround for "rectangular region" screenshots? Thanks again!

@DamirPorobic
Copy link
Member

Sounds like awful lot of steps for such a simple task. I'll try to move this up in my prio list to check what options we have there.

@DamirPorobic DamirPorobic removed this from To do in v1.10.0 Mar 15, 2023
@DamirPorobic DamirPorobic added this to To do in v1.11.0 via automation Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v1.11.0
To do
Development

No branches or pull requests

5 participants