fix ObservableListView & ObservableGridView get the wrong scrollY when restored #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ollY state, reference: ObservableRecyclerView
ksoichiro
added a commit
that referenced
this pull request
Oct 28, 2015
fix ObservableListView & ObservableGridView get the wrong scrollY when restored
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi I'm using this library to implement my own ViewPagerTabActivity, but when I swipe and first Fragment item in FragmentAdapter got destroyed, it can't restore the right scrollY of ObservableListView because of a negative value on mPrevScrolledChildrenHeight. So I commit this change and at the same time I find that ObservableRecyclerView also has the same fix.
fix ObservableListView & ObservableGridView not restore the right scrollY state, reference: ObservableRecyclerView
Please review and accept it. Appreciated for that.