Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tiny suggestion for the samples: add android:fillViewport="true" #21

Closed
AndroidDeveloperLB opened this issue Dec 18, 2014 · 3 comments
Closed

Tiny suggestion for the samples: add android:fillViewport="true" #21

AndroidDeveloperLB opened this issue Dec 18, 2014 · 3 comments

Comments

@AndroidDeveloperLB
Copy link

This is because if others will try to put smaller content (or if the screen is large enough), the bottom area will look weird, as shown here:
http://www.curious-creature.com/2010/08/15/scrollviews-handy-trick/comment-page-1/
@ksoichiro
Copy link
Owner

@AndroidDeveloperLB Thank you for this! I'll add it to the samples which have ScrollViews.

ksoichiro added a commit that referenced this issue Dec 20, 2014
@ksoichiro
Add android:fillViewport="true" to samples using ScrollView. Related …
28bcd7c 
…to issue #21.
@AndroidDeveloperLB
Copy link
Author

@ksoichiro Thank you for this wonderful library.

@ksoichiro
Copy link
Owner

I've added it to all the examples that have ScrollView, so I'll close this issue.
Please reopen it if there is a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ksoichiro @AndroidDeveloperLB