Add android:fillViewport="true" to samples using ScrollView. Related …

…to issue #21.
ksoichiro · Dec 20, 2014 · 28bcd7c · 28bcd7c
1 parent 528f1a7
commit 28bcd7c
Show file tree

Hide file tree

Showing 7 changed files with 12 additions and 5 deletions.
diff --git a/observablescrollview-samples/src/main/res/layout/activity_actionbarcontrolscrollview.xml b/observablescrollview-samples/src/main/res/layout/activity_actionbarcontrolscrollview.xml
@@ -2,7 +2,8 @@
 <com.github.ksoichiro.android.observablescrollview.ObservableScrollView xmlns:android="http://schemas.android.com/apk/res/android"
     android:id="@+id/scroll"
     android:layout_width="match_parent"
-    android:layout_height="match_parent">
+    android:layout_height="match_parent"
+    android:fillViewport="true">
 
     <TextView
         android:layout_width="match_parent"

diff --git a/observablescrollview-samples/src/main/res/layout/activity_fillgapscrollview.xml b/observablescrollview-samples/src/main/res/layout/activity_fillgapscrollview.xml
@@ -10,6 +10,7 @@
         android:id="@+id/scroll"
         android:layout_width="match_parent"
         android:layout_height="match_parent"
+        android:fillViewport="true"
         android:overScrollMode="never"
         android:scrollbars="none">
 

diff --git a/observablescrollview-samples/src/main/res/layout/activity_flexiblespacetoolbarscrollview.xml b/observablescrollview-samples/src/main/res/layout/activity_flexiblespacetoolbarscrollview.xml
@@ -10,14 +10,15 @@
         android:id="@+id/scroll"
         android:layout_width="match_parent"
         android:layout_height="match_parent"
+        android:fillViewport="true"
         android:scrollbars="none">
 
         <FrameLayout
             android:id="@+id/body"
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
-            android:paddingTop="@dimen/flexible_space_height"
-            android:orientation="vertical">
+            android:orientation="vertical"
+            android:paddingTop="@dimen/flexible_space_height">
 
             <TextView
                 android:layout_width="match_parent"

diff --git a/observablescrollview-samples/src/main/res/layout/activity_parallaxtoolbarscrollview.xml b/observablescrollview-samples/src/main/res/layout/activity_parallaxtoolbarscrollview.xml
@@ -9,7 +9,8 @@
     <com.github.ksoichiro.android.observablescrollview.ObservableScrollView
         android:id="@+id/scroll"
         android:layout_width="match_parent"
-        android:layout_height="match_parent">
+        android:layout_height="match_parent"
+        android:fillViewport="true">
 
         <RelativeLayout
             android:layout_width="match_parent"

diff --git a/observablescrollview-samples/src/main/res/layout/activity_slidingupscrollview.xml b/observablescrollview-samples/src/main/res/layout/activity_slidingupscrollview.xml
@@ -66,6 +66,7 @@
             android:layout_width="match_parent"
             android:layout_height="match_parent"
             android:background="@android:color/white"
+            android:fillViewport="true"
             android:overScrollMode="never"
             android:scrollbars="none">
 

diff --git a/observablescrollview-samples/src/main/res/layout/activity_toolbarcontrolscrollview.xml b/observablescrollview-samples/src/main/res/layout/activity_toolbarcontrolscrollview.xml
@@ -9,7 +9,8 @@
     <com.github.ksoichiro.android.observablescrollview.ObservableScrollView
         android:id="@+id/scroll"
         android:layout_width="match_parent"
-        android:layout_height="match_parent">
+        android:layout_height="match_parent"
+        android:fillViewport="true">
 
         <LinearLayout
             android:layout_width="match_parent"

diff --git a/observablescrollview-samples/src/main/res/layout/fragment_scrollview.xml b/observablescrollview-samples/src/main/res/layout/fragment_scrollview.xml
@@ -5,6 +5,7 @@
     android:layout_width="match_parent"
     android:layout_height="match_parent"
     android:background="@android:color/white"
+    android:fillViewport="true"
     android:overScrollMode="never">
 
     <LinearLayout