Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

Consolidate type checking between params and prototypes #44

Closed
jessicayuen opened this issue Nov 4, 2017 · 1 comment
Closed

Consolidate type checking between params and prototypes #44

jessicayuen opened this issue Nov 4, 2017 · 1 comment

Comments

@jessicayuen
Copy link
Contributor

Currently there exists two areas of parameter type checking in cmd/prototype.go and metadata/params/params.go. Since these are operating on the same parameters, we should consolidate this discrepancy.

@jessicayuen
Copy link
Contributor Author

Hmm so I want to say that this might not be possible for the following reason:

The prototype schema has clearly defined parameter types, that the prototype writer can specify. Ex: String, NumberOrString.

The component params are inferred based on the command line input or the literals in the .jsonnet param files.

--

The solution I see around this is 1) removing clearly defined types from prototypes 2) adding clearly defined types to component params.

Neither I think are feasible due to the nature of how these params are provided in each context. Thoughts @hausdorff?

@jessicayuen jessicayuen removed this from the 0.7.0 - Release milestone Dec 11, 2017
@bryanl bryanl closed this as completed Mar 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants