Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

Rename binary to 'ks'; rename 'kubecfg' references to 'ksonnet' #2

Merged
merged 2 commits into from
Oct 17, 2017

Conversation

jessicayuen
Copy link
Contributor

As a part of the migration work from github.com/ksonnet/kubecfg to this repository, we will change the naming of this command line tool to 'ksonnet'. This implies the following changes:

  • Calling the executable 'ks', so that we can run commands such as ks apply dev
  • Rename all references of 'kubecfg' in the codebase to 'ksonnet'.

Partially supports issue #1.

Copy link
Contributor

@hausdorff hausdorff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So. I'd like to propose that we only change the public-facing stuff instead of the internal APIs, because after kubecon we're going to have to pull the common stuff out and merge it back into a common repository, and we don't want to make life harder than it has to be.

@jessicayuen
Copy link
Contributor Author

So. I'd like to propose that we only change the public-facing stuff instead of the internal APIs, because after kubecon we're going to have to pull the common stuff out and merge it back into a common repository, and we don't want to make life harder than it has to be.

Fixed this -- only binary name change (+docs) and import path fixes.

Copy link
Contributor

@hausdorff hausdorff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jessicayuen jessicayuen force-pushed the binary-rename branch 2 times, most recently from 025f6d1 to 45666a7 Compare October 17, 2017 18:15
@jessicayuen jessicayuen force-pushed the binary-rename branch 2 times, most recently from 32ef07f to 19e5963 Compare October 17, 2017 18:20
@hausdorff hausdorff merged commit 6661d13 into ksonnet:master Oct 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants