Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

add option to env set for k8s version spec #618

Merged
merged 1 commit into from Jun 19, 2018

Conversation

underrun
Copy link
Collaborator

@underrun underrun commented Jun 16, 2018

enables --api-spec flag to ks env set command to enable changing the
kubernetes version for an environment

closes #345

@underrun underrun requested review from bryanl and shomron June 16, 2018 00:31
@coveralls
Copy link

coveralls commented Jun 16, 2018

Pull Request Test Coverage Report for Build 1015

  • 12 of 14 (85.71%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 70.798%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/actions/env_set.go 8 10 80.0%
Files with Coverage Reduction New Missed Lines %
pkg/actions/env_set.go 1 62.12%
Totals Coverage Status
Change from base Build 1014: -0.01%
Covered Lines: 10321
Relevant Lines: 14578

💛 - Coveralls

@bryanl
Copy link
Member

bryanl commented Jun 18, 2018

@underrun is this ready to be reviewed? It still has a wip tag?

@underrun underrun changed the title WIP: add option to env set for k8s version add option to env set for k8s version spec Jun 18, 2018
@underrun
Copy link
Collaborator Author

i have un-wip'd

@bryanl
Copy link
Member

bryanl commented Jun 18, 2018

You're going to want to rebase off of master :)

enables --api-spec flag to `ks env set` command to enable changing the
kubernetes version for an environment

Signed-off-by: Derek Wilson <derek@heptio.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow users to set env fields other than name via command line
3 participants