This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
Don't change cluster in apply dry run modified #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add conditionals for object tagging and upserting. Signed-off-by: bryanl <bryanliles@gmail.com>
Pull Request Test Coverage Report for Build 1137
💛 - Coveralls |
underrun
approved these changes
Jul 7, 2018
| @@ -176,7 +176,12 @@ func (a *Apply) handleObject(obj *unstructured.Unstructured) (string, error) { | |||
| // preprocessObject preprocesses an object for it is applied to the cluster. | |||
| func (a *Apply) preprocessObject(obj *unstructured.Unstructured) error { | |||
| dm := newDefaultManaged() | |||
There was a problem hiding this comment.
dryrun could exit earlier if we early out on a.DryRun before this line instead of doing this and then checking if we needed it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add conditionals for object tagging and upserting.
#615
Signed-off-by: bryanl bryanliles@gmail.com