Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

Remove override flag from ks env rm #827

Closed
wants to merge 1 commit into from

Conversation

GuessWhoSamFoo
Copy link
Collaborator

Closes #822

This change ensures ks rm is consistent with ks env set with overriding.

  • ks env rm no longer has an --override flag
  • When overriding an env, it is not possible to change the non-overriden env.

Signed-off-by: GuessWhoSamFoo sfoohei@gmail.com

Signed-off-by: GuessWhoSamFoo <sfoohei@gmail.com>
@GuessWhoSamFoo GuessWhoSamFoo requested a review from a team August 9, 2018 21:19
@bryanl
Copy link
Member

bryanl commented Aug 9, 2018

@GuessWhoSamFoo how do you remove an override?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1276

  • 7 of 9 (77.78%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 70.974%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/actions/env_rm.go 5 7 71.43%
Totals Coverage Status
Change from base Build 1275: -0.02%
Covered Lines: 12050
Relevant Lines: 16978

💛 - Coveralls

@GuessWhoSamFoo
Copy link
Collaborator Author

@bryanl ks env rm will default to the override if it exists.

@GuessWhoSamFoo
Copy link
Collaborator Author

Closed per discussion on UX around this

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants