This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
Fix typeflag reads in tgz.go #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuessWhoSamFoo
force-pushed
the
tar-fix
branch
2 times, most recently
from
a9cc4db
to
c989800
Compare
Pull Request Test Coverage Report for Build 1381
💛 - Coveralls |
|
Can this please be merged? Without this fix one of ksonnet's most important features is only available on osx .. |
|
shipit |
shomron
reviewed
Jan 2, 2019
pkg/util/archive/tgz.go
Outdated
| @@ -62,6 +65,8 @@ func (t *Tgz) Unarchive(r io.Reader, handler FileHandler) error { | |||
| if err = handler(tf); err != nil { | |||
| return err | |||
| } | |||
| default: | |||
| return fmt.Errorf("Unknown header typeflag: %v", header.Typeflag) | |||
There was a problem hiding this comment.
There's a whole bunch of other valid (but skippable) typeflags - I don't think we need to error out if encountering them. Perhaps remove the default and just handle the types we care about?
There was a problem hiding this comment.
Removed the case for TypeDir as well since that was explicitly skipped previously and rebased 👍
Signed-off-by: GuessWhoSamFoo <sfoohei@gmail.com>
GuessWhoSamFoo
force-pushed
the
tar-fix
branch
from
c989800
to
0223a40
Compare
shomron
approved these changes
Jan 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #889
Signed-off-by: GuessWhoSamFoo sfoohei@gmail.com