Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserved files #15

Open
pjf opened this issue Sep 24, 2014 · 1 comment
Open

Preserved files #15

pjf opened this issue Sep 24, 2014 · 1 comment
Labels
Core (ckan.dll) Issues affecting the core part of CKAN Enhancement Spec Issues affecting the spec ★★☆

Comments

@pjf
Copy link
Member

pjf commented Sep 24, 2014

It seems to make a lot of sense to mark some files as preserved, which is going to be most useful for config, but may make sense for other files as well. Preserved files don't need to be included in a distribution, we simply don't delete or overwrite them if they exist when installing or upgrading mods.

Good examples of preserved files are the TACLS and RT2 config overwrites done by RealismOverhaul, but a lot of other mods provide the capability to preserve settings between upgrades.

The rules for preserved files should be pretty simple:

  • When upgrading a mod, we don't remove preserved files.
  • If a mod tries to upgrade a file marked as preserved, we query the user as to what should be done.

The second follows the Debian practice of not overwriting files in /etc that the user may have customised. Care should be taken to ensure the file contents are actually changing before prompting the user.

Preserved files should be used extremely sparingly.

@pjf pjf mentioned this issue Sep 24, 2014
@pjf pjf added this to the Advanced Features. milestone Oct 4, 2014
@pjf pjf added ★★☆ Spec Issues affecting the spec Core (ckan.dll) Issues affecting the core part of CKAN and removed design labels Oct 21, 2014
@pjf pjf modified the milestone: Advanced Features. Oct 27, 2014
@pjf pjf added this to the v1.6.0 milestone Dec 4, 2014
@henrybauer
Copy link

Here's a good example case: WernherChecker (http://forum.kerbalspaceprogram.com/threads/63591) has "checklists" that can (and are) customized by the user (GameData\WernherChecker\Data\WernherChecker.cfg). They should not be overwritten when upgrading, unless the user hasn't modified it.

RichardLake pushed a commit to RichardLake/CKAN that referenced this issue May 30, 2015
RichardLake pushed a commit to RichardLake/CKAN that referenced this issue May 30, 2015
RichardLake pushed a commit to RichardLake/CKAN that referenced this issue May 30, 2015
@pjf pjf modified the milestone: v1.8.0 Jun 23, 2015
@pjf pjf added this to the File Overwrites milestone Jul 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core (ckan.dll) Issues affecting the core part of CKAN Enhancement Spec Issues affecting the spec ★★☆
Projects
None yet
Development

No branches or pull requests

2 participants