Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle 'show' gracefully when plugin not installed #47

Closed
techman83 opened this issue Oct 7, 2014 · 3 comments · Fixed by #51
Closed

Handle 'show' gracefully when plugin not installed #47

techman83 opened this issue Oct 7, 2014 · 3 comments · Fixed by #51
Assignees
Labels
Bug Easy This is easy to fix Merge-pending Ready for merging

Comments

@techman83
Copy link
Member

Not installed

D:\>ckan show AJE

Unhandled Exception: System.Collections.Generic.KeyNotFoundException: The given
key was not present in the dictionary.
   at System.Collections.Generic.Dictionary`2.get_Item(TKey key)
   at CKAN.MainClass.Show(ShowOptions options)
   at CKAN.MainClass.Main(String[] args)

Installed

D:\>ckan install AJE
AJE:

    * Using AJE-1.5.zip (cached)
    * Installing AJE
ModuleManager 2.2.0 already installed, skipping bundled version 2.3.5

Done!

D:\>ckan show AJE
Advanced Jet Engine (AJE) version 1.5
@pjf pjf added this to the Usable Release milestone Oct 7, 2014
@pjf pjf added the Easy This is easy to fix label Oct 7, 2014
@pjf
Copy link
Member

pjf commented Oct 7, 2014

Thank you, and agree! Added to first release milestone. :)

@pjf
Copy link
Member

pjf commented Oct 11, 2014

@techman83 : Fixed in #51! If you fancy glancing over it and merging if it looks good, that would be grand. :)

(Not sure why the unified diff looks so funny, the split diff is much clearer.)

@pjf pjf added Merge-pending Ready for merging and removed help wanted labels Oct 11, 2014
@pjf pjf self-assigned this Oct 11, 2014
@techman83
Copy link
Member Author

@Wizarth appears to have beaten me to it - need to stop spending so much time in the physical world! :)

RichardLake pushed a commit to RichardLake/CKAN that referenced this issue May 30, 2015
RichardLake pushed a commit to RichardLake/CKAN that referenced this issue May 30, 2015
Fixed a possible uncaught exception in Version.cs
RichardLake pushed a commit to RichardLake/CKAN that referenced this issue May 30, 2015
Handle our own escaping for KS URL expansion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Easy This is easy to fix Merge-pending Ready for merging
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants