-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CryoTanks-Core can cause issues because of mods that use NEEDS[CryoTanks] #9911
Comments
Not an expert here, but isn't there a way in MM to need a specific part? If so, can you use that? |
That's this:
Basically, they'd have to pick some cfg file inside CryoTanks that means "all the tank types are installed" and update all of their NEEDS[CryoTanks] to NEEDS[CryoTanks\patches\whatever]. And then hope it doesn't change. And every mod that interacts with the tank types needs to do this. I don't think it's feasible. |
Found one, sort of: NetKAN/NetKAN/SkyhawkScienceSystem.netkan Lines 20 to 21 in 88d4df2
That was based on a third party's use of the metadata-webtool in #9377, so presumably changing it to the full |
So far, post-kerbin-mining-corporation/CryoTanks#138 has sat for 3 weeks with no response. Have we tried contacting @ChrisAdderley via Discord or other means? I know he's busy, but maybe he doesn't receive GitHub pings. Otherwise it seems reasonable to conclude that these metanetkans are not being maintained and reclaim them to solve this and #9894. |
Ooh good catch. According to this list, it doesn't make a distinction: https://github.com/CessnaSkyhawk/SkyhawkScienceSystem/wiki/Mod-Support And the split between core/full seems to only exist in CKAN, and Skyhawk was not originally intended for CKAN. Looking through Skyhawk's configs, it looks like it could work with just cryotanks-core, or the full mod. Just sent a ping on the forum and discord, now we wait... |
@JonnyOThan, how did a user end up in the state of having CryoTanks-Core without CryoTanks, since (almost) no mods depend on CryoTanks-Core? |
That's a good question. I don't recall. |
Did it actually happen? Or was the cause of the error in the OP something else? |
just untangled this nightmare...
https://github.com/JPLRepo/Endurance/blob/14768ade5644ff372e3ad83f134dfba040d1d026/Distribution/GameData/Endurance/Patches/B9PS.cfg#L205
https://github.com/JPLRepo/Endurance/blob/14768ade5644ff372e3ad83f134dfba040d1d026/Distribution/GameData/Endurance/Patches/B9PS.cfg#L298
I'm not really sure how to resolve this in a general way. Ideally installing CryoTanks Core (the simpleboiloff dll) wouldn't satisfy the needs clause, because I'm sure that a lot of mods use NEEDS[CryoTanks] assuming that all of the tank types are installed. That implies it would need to be installed in a different folder. In the current regime, other mods don't have a great way to check for whether the tank types are installed, unless they use NEEDS for a specific cfg file which seems nonobvious and fragile.
A possible solution would be to remove the separation between CryoTanks-Core and CryoTanks - but the .netkan files are on @ChrisAdderley 's repo: https://github.com/post-kerbin-mining-corporation/CryoTanks/tree/master/CKAN
Indeed, there are NO other mods that depend on solely CryoTanks-Core on CKAN, so the separation isn't buying us anything.
Another possible solution for Endurance specifically would be to use its own EN_OX tank type rather than depending on CryoTanks to provide it. But I'm pretty sure we're just going to hit this in other mods too.
@JPLRepo FYI.
The text was updated successfully, but these errors were encountered: