Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-line Modifier Descriptions #25

Closed
r4j4h opened this issue Mar 13, 2013 · 3 comments
Closed

Multi-line Modifier Descriptions #25

r4j4h opened this issue Mar 13, 2013 · 3 comments
Assignees
Milestone

Comments

@r4j4h
Copy link

r4j4h commented Mar 13, 2013

If we define some modifiers such as

// :hover - Something on hover
// .dangerous - Something dangerous

kss-node detects it fine, but if there is one that spans multiple lines, it breaks out of the modifier system and back into normal paragraphs.

// :hover - Something on hover
// .dangerous - Something dangerous.
//                  Be careful to not have a .safe icon inside.

Github ruined the padding [edit: fixed now!], but I would expect it to work like the // Markup:, where it goes until the next empty //

This may be against actual KSS's behavior but I figured I'd bring it up since kss-node has altered the Markup syntax a bit anyway. :)

@0x6a68
Copy link
Contributor

0x6a68 commented Jun 12, 2013

actually i think this would be a feature, we could implement for the next release. i will open up a issue for future ideas on 0.4.0

@0x6a68 0x6a68 closed this as completed Jun 12, 2013
@0x6a68 0x6a68 reopened this Jun 12, 2013
@JohnAlbin JohnAlbin added this to the 1.x milestone Jul 21, 2014
@JohnAlbin JohnAlbin modified the milestones: 2.x, 1.x Jul 24, 2014
@JohnAlbin JohnAlbin modified the milestones: 1.x, 2.x Oct 3, 2014
@JohnAlbin JohnAlbin self-assigned this Oct 3, 2014
@JohnAlbin
Copy link
Contributor

This just became a critical blocker for the Drupal 8 style guide of the Seven admin theme.

@JohnAlbin
Copy link
Contributor

Fixed! Rolling a 1.0.1 release now…

JohnAlbin added a commit that referenced this issue Oct 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants