Added support for SIGTERM #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GLinnik21
requested changes
May 7, 2024
There was a problem hiding this comment.
Great to see the support for SIGTERM signal being added, thanks for this! We're currently focusing on the release-2.0 branch, and since this change isn't critical for version 1, could you please base your changes on release-2.0 instead? Would appreciate your help with this shift!
naftaly
force-pushed
the
Graceful-Termination-Support
branch
from
7cb393a
to
8217d6b
Compare
GLinnik21
requested changes
May 7, 2024
GLinnik21
requested changes
May 9, 2024
Used for sharing the defines for SWIFTPM_MODULE_BUNDLE.
GLinnik21
reviewed
May 9, 2024
GLinnik21
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in getsentry/sentry-cocoa#3895 and firebase/firebase-ios-sdk#12881, this adds support for the SIGTERM signal which Apple often uses before sending SIGKILL.