Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smooth-scroll is causing a conflit #86

Closed
Redani opened this issue Dec 18, 2015 · 11 comments
Closed

smooth-scroll is causing a conflit #86

Redani opened this issue Dec 18, 2015 · 11 comments

Comments

@Redani
Copy link

Redani commented Dec 18, 2015

Dear Karl, thanks for your lovely plugin ;)

I have started to use it but it's causing me a conflict with another scrollable function I use (jquerytools) :/ how can I fix this?

Thanks a lot and happy holidays ;)

@kswedberg
Copy link
Owner

happy holidays to you, too! It must be hard to know if smooth-scroll is causing the conflict or if jquerytools is causing it, right? I've never used jquerytools, so I can't really help without seeing an example of the problem. If you point me to a URL, I'll investigate.

@Redani
Copy link
Author

Redani commented Dec 18, 2015

Thanks Karl for your reply and also for your wishes :)

Haha, yes you're right about accusing which one is causing the conflict :)
here is the link where I had this conflict:, i have unfortunately disabled
smooth-scroll until i solve the problem. If you click on "Mot de passe
oublié ?" the scrollable plugin of jquerytool get's in action!

Thanks a lot for your assistance

@kswedberg
Copy link
Owner

I'm afraid there isn't much I can do to help if I can't see the problem. Also, the scripts that I can see are all minified and obfuscated, making it nearly impossible to determine what's going on.

@Redani
Copy link
Author

Redani commented Dec 20, 2015

oh that's a bad news, and can't do much about the code :/

well, i've already found the problem, i use jquerytools plugin that has a
scrollable function:
http://jquerytools.github.io/demos/scrollable/index.html and in your plugin
you have this: t.fn.extend({scrollable:function(t){var
e=s.call(this,{dir:t});return this.pushStack(e)} ... which is causing a
conflict...
so i'm wondering if i can renale your "scrollable" by "smoothscrollable"
for example...

@kswedberg
Copy link
Owner

Sure. Give it a shot.

@Redani
Copy link
Author

Redani commented Dec 20, 2015

well, it seems to be working, but i'm confused about your "scrollable"
function, what is it for ?

@kswedberg
Copy link
Owner

In my plugin $.fn.scrollable is a traversing method that filters a jQuery collection to include only the elements that are scrollable. For example, if I were to do $('html, body').scrollable(), it would return a jQuery object consisting of …

  • the body element in Chrome
  • the html element in Firefox
  • both html and body in older versions of Opera

@kswedberg
Copy link
Owner

Closing this for now. Let me know if you have any other questions.

@Redani
Copy link
Author

Redani commented Dec 22, 2015

OK, thank you very much for the explanations ;)
So, you confirm that naming "scrollable" into "smoothScrollable" will have
no consequences ?

Thanks

@Redani
Copy link
Author

Redani commented Dec 22, 2015

Hi again Karl,
I've just realised that I have more errors :/ i'll PM you a link tot a test page so you can also see the problem of scrollable...

Thanks a lot

@kswedberg
Copy link
Owner

Ok, thanks.

--Karl

On Dec 22, 2015, at 4:36 PM, Redani notifications@github.com wrote:

Hi again Karl,
I've just realised that I have more errors :/ i'll PM you a link tot a test page so you can also see the problem of scrollable...

Thanks a lot


Reply to this email directly or view it on GitHub #86 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants