fix: add/remove aria-label attrs to appease a11y checkers

kswedberg · Oct 30, 2021 · b48cf4e · b48cf4e
1 parent f617767
commit b48cf4e
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/example/nuxt.config.js b/example/nuxt.config.js
@@ -18,7 +18,11 @@ module.exports = {
       { charset: 'utf-8' },
       { name: 'viewport', content: 'width=device-width, initial-scale=1' },
     ],
+    htmlAttrs: {
+      lang: 'en',
+    },
   },
+
   rootDir: resolve(__dirname),
   buildDir: resolve(__dirname, './.nuxt'),
   srcDir: __dirname,

diff --git a/lib/components/Breaky.vue b/lib/components/Breaky.vue
@@ -42,7 +42,6 @@
       </TransitionExpand>
 
       <div
-        aria-label="Current breakpoint"
         class="current-breakpoint transition duration-300 text-center border-2 border-transparent py-2 px-4 rounded-full flex items-center justify-around"
         :class="{ 'border-opacity': !expanded }"
       >

diff --git a/lib/components/CurrentScreenIcon.vue b/lib/components/CurrentScreenIcon.vue
@@ -3,11 +3,11 @@
     <!-- Desktop -->
     <svg
       v-show="screenWidth > 1024"
-      aria-hidden="true"
       focusable="false"
       data-icon="desktop"
       class="h-4 mr-3 fill-current"
       role="img"
+      aria-label="Desktop"
       xmlns="http://www.w3.org/2000/svg"
       viewBox="0 0 576 512"
     >
@@ -19,11 +19,11 @@
     <!-- Tablet -->
     <svg
       v-show="screenWidth <= 1024 && screenWidth > 768"
-      aria-hidden="true"
       focusable="false"
       data-icon="tablet-alt"
       class="h-4 mr-3 fill-current"
       role="img"
+      aria-label="Tablet"
       xmlns="http://www.w3.org/2000/svg"
       viewBox="0 0 448 512"
     >
@@ -35,11 +35,11 @@
     <!-- Mobile -->
     <svg
       v-show="screenWidth <= 768"
-      aria-hidden="true"
       focusable="false"
       data-icon="mobile-alt"
       class="h-4 mr-3 fill-current"
       role="img"
+      aria-label="Mobile"
       xmlns="http://www.w3.org/2000/svg"
       viewBox="0 0 320 512"
     >