add aspect ratio detection for amcodec h264 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chbmuc Once again thanks for contributing. Would it be OK with you if I cherry-pick that commit with some file name changes instead of merging PR? That would be easier to maintain for me. I will keep your authorship, of course. |
|
Of course! Just use it the way you want. - As you can see in the patches, most of the code isn't even my authorship. |
|
Added in 6cab0e2 Thank you! |
Wilhansen
pushed a commit
to Wilhansen/LibreELEC.tv
that referenced
this pull request
Dec 30, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the Forum, amcodec is missing an aspect ratio detection.
The patch from @tarvip works great for me. The only thing I've added is a default aspect ratio for "HD Lite" channels.