New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
projects/S905: Delete cputemp #5
Conversation
Current cputemp contains same code than packages/mediacenter/kodi/scripts/cputemp
In any case not is working on S905X |
The script is not 100% the same as the project-specific one doesn't divide returned temperature value by 1000. On the other hand, you are correct that this file is not needed as Amlogic 3.14 kernel returns temperature value in millicelsius. I have 2 requests to this PR: please also delete Kodi patch for temperature scaling and reword commit message to include "projects/S905". Thanks. If you want to make temperature sensor work, you can enable it in kernel config. It will work for S905X but with S905 the only thing you get is spammed kmsg - that's the reason why I don't enable it for my builds. |
File not need, contains the same code than packages/mediacenter/kodi/scripts/cputemp
Thank you! |
Works fine on S905X after compile again the kernel. |
The issue with S905 is not in |
Let me understand the problem. You not compile that option in the kernel because get incorrect information for S905, but works fine for S905X My proposed solution is compile the kernel with the temperature sensor, and create a new cputemp that only return values for the revision 020a that I assume that should match only with S905X Something like this (I haven tested the code sorry I'll do latter)
This will get a value at least for S905X, fix the kernel thermal driver is out of my skills. But I need to confirm that the "Revision" approach is the correct way to identify the S905X over the S905 |
No. The issue is that if you compile kernel with TEMP_SENSOR enabled, kernel log is spammed with thermal driver messages. It is not a big issue for a user but for me it makes debugging very unpleasant. I may disable thermal driver for S905 in |
add new files
File not need, contains the same code than packages/mediacenter/kodi/scripts/cputemp