Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow DOCTYPE declaration #16

Merged
merged 1 commit into from
Jun 21, 2014
Merged

allow DOCTYPE declaration #16

merged 1 commit into from
Jun 21, 2014

Conversation

gesellix
Copy link
Contributor

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling e83c370 on gesellix:allow-doctype-decl into a69e7ad on kt3k:master.

@kt3k
Copy link
Owner

kt3k commented Jun 19, 2014

Hi, @gesellix

Thanks for contribution!

But it seems a bit strange because the document says that the default for this option is false. Do you have any idea about why the above example fails because of this option's setting?

@gesellix
Copy link
Contributor Author

Hi @kt3k

I don't have examined the reason behind the problem, but if you have a look at the build at travis-ci you'll see why I came up with this.
I would guess that the linked documentation is correct for Xerces-J 2.3.0+, but I didn't examine which xml parser is actually used in my build. If you like, I'll try to find out :)

@kt3k
Copy link
Owner

kt3k commented Jun 21, 2014

I want to know a little more about why this happened because in the previous build no problems occured.
But this change seems mostly harmless for any environment, so I'm going to merge this for now.

If you find out the reason, please let me know.

kt3k added a commit that referenced this pull request Jun 21, 2014
@kt3k kt3k merged commit 7cbef5e into kt3k:master Jun 21, 2014
@kt3k
Copy link
Owner

kt3k commented Jun 21, 2014

Deployed this version as v0.4.1.

@gesellix
Copy link
Contributor Author

Thanks for merging!

One reason could be the update of Gradle zu the current 2.0-RC-1. I guess some dependencies have changed, so that another xml parser is used. I didn't compare the previous with the current dependencies, though.

@gesellix
Copy link
Contributor Author

the build has been fixed after updating to the current coveralls plugin: https://travis-ci.org/gesellix-docker/docker-client/builds/28103407

@kt3k
Copy link
Owner

kt3k commented Jun 21, 2014

It's nice! thanks for checking.

@gesellix gesellix deleted the allow-doctype-decl branch June 21, 2014 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants