-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow DOCTYPE declaration #16
Conversation
Hi, @gesellix Thanks for contribution! But it seems a bit strange because the document says that the default for this option is |
Hi @kt3k I don't have examined the reason behind the problem, but if you have a look at the build at travis-ci you'll see why I came up with this. |
I want to know a little more about why this happened because in the previous build no problems occured. If you find out the reason, please let me know. |
Deployed this version as v0.4.1. |
Thanks for merging! One reason could be the update of Gradle zu the current 2.0-RC-1. I guess some dependencies have changed, so that another xml parser is used. I didn't compare the previous with the current dependencies, though. |
the build has been fixed after updating to the current coveralls plugin: https://travis-ci.org/gesellix-docker/docker-client/builds/28103407 |
It's nice! thanks for checking. |
see http://xerces.apache.org/xerces2-j/features.html#disallow-doctype-decl
example for breaking build due to doctype checking: https://travis-ci.org/gesellix-docker/gradle-docker-plugin/builds/27949346