Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support coverage calculated from PIT mutation tests #71

Merged
merged 3 commits into from
Feb 5, 2017
Merged

Support coverage calculated from PIT mutation tests #71

merged 3 commits into from
Feb 5, 2017

Conversation

thejohnfreeman
Copy link
Contributor

Closes #70

@thejohnfreeman
Add PIT report fixture
7d82b17 
Add the source files for a small Java project, and a PIT XML report
generated from its tests, as fixtures. The project is kt3k's own
BankAccount-DCI at commit cca6b9c5803aaec5175d0cb725ea469d213752f1.

https://github.com/kt3k/BankAccount-DCI/tree/cca6b9c5803aaec5175d0cb725ea469d213752f1
@thejohnfreeman
Support PIT reports in XML
b681e8f
@thejohnfreeman
Fix tests
990414c
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.6%) to 94.969% when pulling 990414c on thejohnfreeman:master into d6d9543 on kt3k:master.

@thejohnfreeman
Copy link
Contributor Author

After pushing this latest fix, the build passed with oraclejdk8 and failed with oraclejdk7. I believe that failure is spurious, caused by some transient internet connectivity problem. I believe that if you restart the build, which I cannot do, then it will pass.

The fall in coverage is due to following the pattern for the JacocoSourceReportFactoryTest where only the static method is tested, but not the instance method that finds the source directories.

@thejohnfreeman thejohnfreeman reopened this Feb 5, 2017
@kt3k
Copy link
Owner

kt3k commented Feb 5, 2017

Thanks for the constribution!

All looks good to me. I agree that the test failure in travis (oraclejdk7) is irrelevant of this PR. (I found similar issue.)

I'll publish this version in a few days.

@kt3k kt3k merged commit 4c6790b into kt3k:master Feb 5, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.6%) to 94.969% when pulling 990414c on thejohnfreeman:master into d6d9543 on kt3k:master.

@kt3k
Copy link
Owner

kt3k commented Feb 6, 2017

Published as v2.8.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thejohnfreeman @coveralls @kt3k