Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(install_util): add support for DENO_DIR #31

Merged
merged 2 commits into from
Dec 5, 2021

Conversation

uki00a
Copy link
Contributor

@uki00a uki00a commented Dec 5, 2021

This PR changes install_util.ts to install esbuild.wasm into DENO_DIR if it is defined.

@kt3k
Copy link
Owner

kt3k commented Dec 5, 2021

@uki00a
I'm ok with this addition but can you elaborate a little bit on the motivation of this change?

Do you usually specify DENO_DIR somewhere different from the default?

@uki00a
Copy link
Contributor Author

uki00a commented Dec 5, 2021

@kt3k

Do you usually specify DENO_DIR somewhere different from the default?

Yes, I've specified the DENO_DIR explicitly in my ~/.zshrc.

I'm using asdf-deno to manage multiple Deno environments.

asdf-deno is dynamically switching DENO_DIR depending on the currently enabled Deno version.

For example, if the currently enabled version of Deno is v1.16.4, the following directory will be set to DENO_DIR:

~/.asdf/installs/deno/1.16.4/.cache/deno

To avoid this behavior by asdf-deno, I've explicitly set DENO_DIR in ~/.zshrc as follows:

export DENO_DIR=$HOME/.cache/deno

Therefore, I wanted esbuild.wasm used by packup to also be installed in ~/.cache/deno instead of ~/.deno 🙂

Copy link
Owner

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your explanation! Ok. Let's do this!

@kt3k kt3k merged commit aaae96a into kt3k:main Dec 5, 2021
@uki00a uki00a deleted the installer-should-respect-DENO_DIR branch December 5, 2021 10:48
@kt3k
Copy link
Owner

kt3k commented Dec 5, 2021

published as v0.1.10

@uki00a
Copy link
Contributor Author

uki00a commented Dec 5, 2021

Thanks for the review and release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants