Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid code: static const #14

Closed
snwflake opened this issue Mar 7, 2019 · 2 comments
Closed

Invalid code: static const #14

snwflake opened this issue Mar 7, 2019 · 2 comments

Comments

@snwflake
Copy link
Contributor

snwflake commented Mar 7, 2019

In point 4 Do not use Screaming Caps for constants or readonly variables: your example uses

// Correct
public static const string ShippingType = "DropShip";

which is invalid. const implies static and is therefore neither needed, nor allowed.
@ktaranov
Copy link
Owner

ktaranov commented Mar 9, 2019

Hi, @snwflake. Thanks for issue. Could you prepare pull request for it?

@snwflake
Copy link
Contributor Author

snwflake commented Mar 9, 2019

done.
#15

ktaranov added a commit that referenced this issue Mar 9, 2019
@ktaranov
Merge pull request #15 from snwflake/master
9ccc1c6 
fix #14 remove invalid qualifier static
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ktaranov @snwflake