Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getting errors while running tests in test_netmiko_config.py in develop branch #892

Closed
mvsiva opened this issue Jul 27, 2018 · 4 comments
Closed

Comments

@mvsiva
Copy link
Contributor

mvsiva commented Jul 27, 2018

getting errors while running tests..

def test_save_response(net_connect, commands, expected_responses):
    '''
    Test save config with the confirm response parameter.
    '''
    confirm_response = commands['save_config_response']
    save_verify = expected_responses['save_config']
  cmd_response = net_connect.save_config(confirm_response=confirm_response)

E TypeError: save_config() got an unexpected keyword argument 'confirm_response'

test_netmiko_config.py:135: TypeError

@ktbyers
Copy link
Owner

ktbyers commented Jul 27, 2018

@mvsiva Yes, the develop branch has some issues on the save_config tests that I need to fix.

@ktbyers
Copy link
Owner

ktbyers commented Jul 27, 2018

I would probably just comment out all of the test_save_* tests for now (in test_netmiko_config.py).

@mvsiva
Copy link
Contributor Author

mvsiva commented Aug 2, 2018

Think I have corrected test_netmiko_config.py as part of PR #893 . You can review and pull the changes if they are ok..

@mvsiva
Copy link
Contributor Author

mvsiva commented Aug 6, 2018

As save_config tests are now decoupled, closing this issue.

@mvsiva mvsiva closed this as completed Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants