release: support pelc_product_version_name parameter

and update the inline documentation
ktdreyer · Sep 11, 2020 · c43e049 · c43e049
1 parent 1612df2
commit c43e049
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/library/errata_tool_release.py b/library/errata_tool_release.py
@@ -150,7 +150,11 @@
      required: false
    pelc_product_version_name:
      description:
-       - Set to "null" if this release does not use PELC.
+       - If your release does not use PELC, you can omit this parameter and
+         the ET server will default this value to "null".
+       - If the ET server already has a PELC version defined for this release
+         and you wish to *unset* it, set this pelc_product_version_name
+         parameter to an empty string "".
      default: null
      required: false
    brew_tags:
@@ -309,9 +313,6 @@ def api_data(client, params):
             release['state_machine_rule_set_id'] = rule_set_id
         else:
             release['state_machine_rule_set_id'] = None
-    # "pelc_product_version_name" - not yet supported in the create/update
-    # API, so we silently skip this setting for now:
-    release.pop('pelc_product_version_name', None)
     # "blocker_flags" list -> str
     if 'blocker_flags' in release:
         release['blocker_flags'] = ",".join(release['blocker_flags'])

diff --git a/tests/test_errata_tool_release.py b/tests/test_errata_tool_release.py
@@ -147,7 +147,7 @@ def test_create_release(self, client, params):
                 'allow_shadow': False,
                 'allow_blocker': False,
                 'internal_target_release': '',
-                # 'pelc_product_version_name': None,  # see issue #94
+                'pelc_product_version_name': None,
                 'disable_acl': False,
                 'allow_pkg_dupes': True,
                 'limit_bugs_by_product': False,
@@ -197,7 +197,7 @@ def test_create_async_no_product(self, client, params):
                 'allow_shadow': False,
                 'allow_blocker': False,
                 'internal_target_release': '',
-                # 'pelc_product_version_name': None,  # see issue #94
+                'pelc_product_version_name': None,
                 'disable_acl': False,
                 'allow_pkg_dupes': True,
                 'limit_bugs_by_product': False,