Check points #9
Merged
Check points #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To keep things simple for now, I only check whether the initial z0 locations provided are within 1m of the bottom. I do this by making an interpolation function for water depth, and checking the water depth at the provided (lon0, lat0) locations.
…re_for_model_run not working because the particle was just below the bottom even after running the check. But that problem doesn't happen anymore. So, make the check cleaner until I run into the problem again.
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated tools.check_points to take in an input array of z0 values and check whether they are within 1m of the bottom. The 1m restriction is arbitrary for now, but works well. I do the check by interpolating to find out water depth at the (lon0, lat0) location and checking whether z0 is above that.