Avoid deleting incomplete type (shogun-toolbox#4095)

ktiefe · Jul 26, 2019 · 2801aef · 2801aef
1 parent 2ae6141
commit 2801aef
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/shogun/base/class_list.cpp.templ b/src/shogun/base/class_list.cpp.templ
@@ -69,3 +69,8 @@ CSGObject* shogun::create(const char* classname, EPrimitiveType generic)
 
 	return NULL;
 }
+
+void shogun::delete_object(CSGObject* object)
+{
+	delete object;
+}
diff --git a/src/shogun/base/class_list.h b/src/shogun/base/class_list.h
@@ -22,6 +22,11 @@ namespace shogun {
 	 */
 	CSGObject* create(const char* sgserializable_name, EPrimitiveType generic);
 
+	/** deletes object
+	 * @param object pointer to object to be deleted
+	 */
+	void delete_object(CSGObject* object);
+
 	/** Creates new shogun instance, typed.
 	 *
 	 * Throws an exception in case there is no such classname or
@@ -39,7 +44,7 @@ namespace shogun {
 		auto* cast = dynamic_cast<T*>(object);
 		if (!cast)
 		{
-			delete object;
+			delete_object(object);
 			SG_SERROR("Type mismatch");
 		}
 		cast->ref();