Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of CartPole Environment, and some Error Corrections #2

Merged
merged 5 commits into from Dec 1, 2021

Conversation

hojin1117
Copy link
Contributor

Hi Taekyung Kim,
the objective of this request is to add continuous cartpole environment and to apply slight modifications on your work.

  1. New Environment
  • I added continuous action cartpole environment in your work. Unlike cartpole environment of openAI gym in which action is discrete(Left or Right), in this environment, action varies continuously from -10.0 to 10.0.
  • The magnitude of wind is converted into magnitude of torque(wind_torque), and then it is applied to system dynamics in 'step' function.
  1. Error Correction
  • If the sign of wind is plus(+), wind blows from left to right. Otherwise, wind blows from right to left. So I modified 'Line 117-118' of 'unstable_pendulum.py' to fit this sign convention.
  • Deletion of some print commands in 'unstable_pendulum.py'
  • Some Typo Corrections

Thanks for your great work, Taekyung.

@tkkim-robot
Copy link
Owner

Thanks for your work hojin1117.

I reviewed your commits and I think it is suitable to merge to master.

But I'm afraid the visualization in "unstable_pendulum.py" is still correct on the original version.
Please check the 'sign' again and let me know.

Best.

@hojin1117
Copy link
Contributor Author

Hi Taekyung Kim,
I modified sign convention on "unstable_pendulum.py", and renamed some files for simplicity.
Thanks for your great work.

@tkkim-robot tkkim-robot merged commit 126d63e into tkkim-robot:master Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants