Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mapdir: use EOPNOTSUPP for xattr #245

Merged
merged 1 commit into from
Mar 7, 2024
Merged

mapdir: use EOPNOTSUPP for xattr #245

merged 1 commit into from
Mar 7, 2024

Conversation

ktock
Copy link
Owner

@ktock ktock commented Mar 7, 2024

Currently (unimplemented) 9pfs's xattr returns ENOTSUP but ls (GNU coreutils) prints error message for this errno. This commit fixes this by using EOPNOTSUPP instead, for supressing the error message.

$ wasmtime --mapdir /test/dir/share::/tmp/share/ /app/out.wasm ls -al /test/dir/share/
ls: /test/dir/share/: Unknown error 524
ls: /test/dir/share/.: Unknown error 524
ls: /test/dir/share/a: Unknown error 524
total 0
d--------- 1 root root  0 Jan  1  1970 .
drwxr-xr-x 3 root root 60 Mar  7 09:45 ..
---------- 1 root root  3 Mar  7 09:05 a

Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
@ktock ktock merged commit d3555d3 into main Mar 7, 2024
13 checks passed
@ktock ktock deleted the xattrerrno branch March 7, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant