Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tracing to Apache HttpClient engine #1246

Closed
howareyouman opened this issue Jul 24, 2019 · 4 comments
Closed

Add tracing to Apache HttpClient engine #1246

howareyouman opened this issue Jul 24, 2019 · 4 comments
Assignees
Labels

Comments

@howareyouman
Copy link

Subsystem
Engine for HttpClient - ApacheEngine

Is your feature request related to a problem? Please describe.
It seems like it's not possible to create HttpClient with Apache engine with Tracing component inside.

Describe the solution you'd like
It will be nice to construct HttpClient with custom implementation of HttpAsyncClientBuilder inside and use tracing feature implicitly.

Motivation to include to ktor
All api with clientBuilder is internal and there is no way to override it without support of ktor client.

@e5l
Copy link
Member

e5l commented Jul 24, 2019

Hi @howareyouman, thanks for the report.
Do you have an idea of how it should look?

@e5l e5l self-assigned this Jul 24, 2019
@howareyouman
Copy link
Author

howareyouman commented Jul 24, 2019

@e5l Smth like this:
HttpClient(Apache) { engine { setTracing(tracing) } }

@oleg-larshin
Copy link

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.

@Stexxe
Copy link
Contributor

Stexxe commented Jun 21, 2021

You can customize an instance of HttpAsyncClientBuilder with the following code:

HttpClient(Apache) {
    engine {
        customizeClient { // this: HttpAsyncClientBuilder

        }
    }
}

But it doesn't have the setTracing method.

@Stexxe Stexxe closed this as completed Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants