Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CIO: allow empty header values #853

Closed
Miha-x64 opened this issue Jan 6, 2019 · 0 comments
Closed

CIO: allow empty header values #853

Miha-x64 opened this issue Jan 6, 2019 · 0 comments
Assignees
@e5l
Labels
bug up for grabs Involve simple fixes and/or implementations which are great for folks wanting to contribute
Milestone
1.1.2

Comments

@Miha-x64
Copy link

Miha-x64 commented Jan 6, 2019 •
edited

Ktor Version

1.1.1

Ktor Engine Used(client or server and name)

CIO

JVM Version, Operating System and Relevant Context

irrelevant

Feedback

GitHub REST API v3 returns empty X-OAuth-Scopes and X-Accepted-OAuth-Scopes headers for me. Looks like it is not explicitly prohibited by RFC, too.

throw location: io/ktor/http/cio/HttpParser.kt:116
@e5l e5l self-assigned this Jan 7, 2019
@e5l e5l added bug up for grabs Involve simple fixes and/or implementations which are great for folks wanting to contribute labels Jan 7, 2019
e5l added a commit that referenced this issue Jan 14, 2019
@e5l
Fix CIO headers parsing
3ddf5a7 
    Closes #853
e5l added a commit that referenced this issue Jan 14, 2019
@e5l
Fix CIO headers parsing
f80eb96 
    Closes #853
@e5l e5l closed this as completed in 4625b71 Jan 16, 2019
@cy6erGn0m cy6erGn0m added this to the 1.1.2 milestone Jan 24, 2019
schleinzer pushed a commit to schleinzer/ktor that referenced this issue Feb 26, 2019
@e5l
Fix CIO headers parsing
cf45862 
    Closes ktorio#853
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@e5l e5l

Labels
bug up for grabs Involve simple fixes and/or implementations which are great for folks wanting to contribute
Projects
None yet
Milestone
1.1.2
Development

No branches or pull requests
3 participants
@cy6erGn0m @e5l @Miha-x64