Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KTOR-1464 Fix client Digest auth realm handling #2347

Merged
merged 1 commit into from
Apr 29, 2021

Conversation

cy6erGn0m
Copy link
Contributor

@cy6erGn0m cy6erGn0m commented Feb 10, 2021

Fix client digest auth realm handling to use the realm provided by the server if the realm is not configured in the client feature

Subsystem
ktor-client-auth

Motivation
Digest authentition: using the realm of the 401 response to an initial incomplete request for an immediate second complete request including realm.

This replaces PR #2236

@cy6erGn0m cy6erGn0m added this to the 1.5.2 milestone Feb 10, 2021
@cy6erGn0m cy6erGn0m requested a review from e5l February 10, 2021 10:28
@cy6erGn0m cy6erGn0m self-assigned this Feb 10, 2021
Copy link
Member

@e5l e5l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Fix client digest auth realm handling to use the realm provided by the server if the realm is not configured in the client feature
@cy6erGn0m cy6erGn0m merged commit 6e5fb98 into main Apr 29, 2021
@cy6erGn0m cy6erGn0m deleted the cy/digest-auth-server-realm branch April 29, 2021 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants