Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KTOR-1460 Switch to org.w3c.fetch #2592

Closed
wants to merge 1 commit into from
Closed

KTOR-1460 Switch to org.w3c.fetch #2592

wants to merge 1 commit into from

Conversation

hfhbd
Copy link
Contributor

@hfhbd hfhbd commented Sep 5, 2021 •
edited

2nd PR after KTOR-2230

Subsystem
Client, JS

Motivation
KTOR-1460

  • browser: Reduce code size by using std lib provided fetch api/classes
  • nodeJS: added minimal defined classes manually

Solution
Switch to org.w3c.fetch or use manually defined classes on nodeJS

@hfhbd
Copy link
Contributor Author

hfhbd commented Sep 5, 2021

As you can not test nodeJsProductionRun in unit tests, I used this test project: https://github.com/hfhbd/ktorTestNodeJS with mavenLocal

@e5l e5l self-requested a review September 7, 2021 11:36
e5l
e5l reviewed Sep 7, 2021
View reviewed changes
Copy link
Member

@e5l e5l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can be merged after CI run

@e5l e5l self-requested a review September 7, 2021 11:37
@hfhbd hfhbd marked this pull request as draft September 15, 2021 19:01
@hfhbd hfhbd marked this pull request as ready for review September 15, 2021 21:27
@hfhbd hfhbd marked this pull request as draft September 15, 2021 21:28
@e5l e5l deleted the branch ktorio:main October 4, 2021 07:53
@e5l e5l closed this Oct 4, 2021
@e5l e5l reopened this Oct 4, 2021
@e5l e5l changed the base branch from 2.0.0-eap to main October 4, 2021 12:41
@hfhbd hfhbd closed this Oct 6, 2021
@hfhbd hfhbd deleted the hfhbd/KTOR-1460-2.0.0 branch October 6, 2021 17:01
@hfhbd hfhbd restored the hfhbd/KTOR-1460-2.0.0 branch October 7, 2021 12:29
@hfhbd hfhbd reopened this Oct 7, 2021
@hfhbd hfhbd marked this pull request as ready for review October 20, 2021 13:09
@rsinukov
Copy link
Contributor

Hi @hfhbd. JS tests are failing on CI

@hfhbd hfhbd marked this pull request as draft November 2, 2021 18:21
@e5l e5l force-pushed the main branch 2 times, most recently from d084312 to 1ae2c1f Compare April 6, 2022 06:43
@hfhbd hfhbd mentioned this pull request Jun 13, 2022
Merged
@e5l
Copy link
Member

e5l commented Jul 8, 2022

Could you rebase if if it's actual or should we close?

@hfhbd
Copy link
Contributor Author

hfhbd commented Oct 19, 2022

Sorry for the late answer. I rebased it, but removing the classes will break abi.

@hfhbd hfhbd closed this Oct 19, 2022
@hfhbd hfhbd deleted the hfhbd/KTOR-1460-2.0.0 branch October 19, 2022 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e5l e5l e5l approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hfhbd @rsinukov @e5l