Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KTOR-3422 Upgrade kotlin to 1.6.0 #2693

Merged
merged 1 commit into from Nov 16, 2021
Merged

KTOR-3422 Upgrade kotlin to 1.6.0 #2693

merged 1 commit into from Nov 16, 2021

Conversation

e5l
Copy link
Member

@e5l e5l commented Nov 16, 2021

Fix KTOR-3422

@e5l e5l requested a review from lolilofit November 16, 2021 08:17
@e5l e5l self-assigned this Nov 16, 2021
lolilofit
lolilofit approved these changes Nov 16, 2021
View reviewed changes
Copy link
Contributor

@lolilofit lolilofit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hfhbd
Copy link
Contributor

hfhbd commented Nov 16, 2021

What about coroutines, especially for new MM with 1.6.0?

@e5l
Copy link
Member Author

e5l commented Nov 16, 2021

@hfhbd, the new MM support is merged. All you need to do is take kotlinx.coroutines version with support(when it will be released) and provide it as a dependency. You also need to specify the flag to enable a new memory model.

@e5l e5l merged commit b51e2f6 into main Nov 16, 2021
@e5l e5l deleted the e5l/kotlin branch November 16, 2021 11:24
e5l added a commit that referenced this pull request Nov 25, 2021
@e5l
KTOR-3422 Upgrade kotlin to 1.6.0 (#2693)
e8531a1
e5l added a commit that referenced this pull request Nov 25, 2021
@e5l
KTOR-3422 Upgrade kotlin to 1.6.0 (#2693)
8e6e831
@webfrea-k webfrea-k mentioned this pull request Dec 13, 2021
Closed
@hfhbd hfhbd mentioned this pull request Jan 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolilofit lolilofit lolilofit approved these changes

Assignees

@e5l e5l

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@e5l @hfhbd @lolilofit