Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Netty: ApplicationStarted event is fired before the server starts accepting connections #3286

Merged
merged 2 commits into from
Dec 7, 2022
Merged

Netty: ApplicationStarted event is fired before the server starts accepting connections #3286

merged 2 commits into from
Dec 7, 2022

Conversation

Stexxe
Copy link
Contributor

@Stexxe Stexxe commented Dec 5, 2022

@Stexxe Stexxe requested a review from e5l December 5, 2022 20:04
e5l
e5l approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@e5l e5l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please add the ticket number to the start of the PR name

@Stexxe Stexxe merged commit 04a9791 into main Dec 7, 2022
@Stexxe Stexxe deleted the stexxe/server-ready-event-KTOR-4259 branch December 7, 2022 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e5l e5l e5l approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Stexxe @e5l