KTOR-6909 Add SocketTimeout for Test Engine #4021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marychatte
force-pushed
the
marychatte/KTOR-6909-Test-client-ignores-socket-timeout
branch
from
93a91af
to
84b81e9
Compare
e5l
reviewed
Apr 16, 2024
| @@ -271,11 +275,13 @@ public class TestApplicationEngine( | |||
| public fun createCall( | |||
| readResponse: Boolean = false, | |||
| closeRequest: Boolean = true, | |||
| timeoutAttributes: HttpTimeoutConfig? = null, | |||
There was a problem hiding this comment.
could we try making it without API change?
marychatte
force-pushed
the
marychatte/KTOR-6909-Test-client-ignores-socket-timeout
branch
from
84b81e9
to
0f46c12
Compare
e5l
approved these changes
Apr 26, 2024
marychatte
deleted the
marychatte/KTOR-6909-Test-client-ignores-socket-timeout
branch
bjhham
pushed a commit
that referenced
this pull request
Apr 30, 2024
bjhham
pushed a commit
that referenced
this pull request
Apr 30, 2024
Merged
bjhham
added a commit
that referenced
this pull request
Apr 30, 2024
bjhham
added a commit
that referenced
this pull request
Apr 30, 2024
marychatte
added a commit
that referenced
this pull request
Apr 30, 2024
bjhham
pushed a commit
that referenced
this pull request
May 6, 2024
bjhham
added a commit
that referenced
this pull request
May 6, 2024
bjhham
added a commit
that referenced
this pull request
May 6, 2024
bjhham
pushed a commit
that referenced
this pull request
May 6, 2024
bjhham
pushed a commit
that referenced
this pull request
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
Test Client
Motivation
KTOR-6909