Fix multiple dispatch problem with async servlet timeouts. #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cy6erGn0m
reviewed
Nov 30, 2016
|
|
||
| @Test | ||
| fun foo(){ | ||
| val port = 44003 |
There was a problem hiding this comment.
fixed port number is not good, see findFreePort
| class MultipleDispatchOnTimeout { | ||
|
|
||
| @Test | ||
| fun foo(){ |
|
Yes. About 2.8 seconds. However, it is mostly a proof of concept for the problem. Maybe the correct solution would be to set the timeout to 0 globally ? Or handled some other way ? |
|
A temporary workaround: |
|
@spand merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Servlet containers with async context will redispatch after a timeout. In Jettys case the default seems to be 30 secs. I think it is part of the three steps discribed here: https://docs.oracle.com/javaee/6/api/javax/servlet/AsyncContext.html
The provided testcase fails without the fix.
This might also be the cause of what we are seeing in #52