Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added code to ensure that passwords are not included git.remote.origin.url #241

Merged
merged 1 commit into from
Mar 26, 2016

Conversation

damnhandy
Copy link
Contributor

PR for issue #240

@ceefour
Copy link

ceefour commented Mar 26, 2016

👍 this is a security issue

@@ -0,0 +1,54 @@
package pl.project13.maven.git;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing license header, I'll add

@ktoso
Copy link
Collaborator

ktoso commented Mar 26, 2016

LGTM, thanks a lot for noticing and the fix - I would not have noticed as currently not using Maven in any of the projects I maintain (except this one).

I'll merge and cut a release shortly after today as you're right that it's a security issue.

@ktoso ktoso merged commit c2997b8 into git-commit-id:master Mar 26, 2016
@damnhandy
Copy link
Contributor Author

Thanks for taking the change. This plugin is extremely useful to me and my teams. Interestingly, the core issue is really not in this plugin, but your code was easier to jump in and make a fix. It's well organized and has great test cases.

@ktoso
Copy link
Collaborator

ktoso commented Mar 26, 2016

This plugin is extremely useful to me and my teams. Interestingly, the core issue is really not in this plugin, but your code was easier to jump in and make a fix. It's well organized and has great test cases.

I'm very glad to hear that. Yeah, it's not really our fault but let's clean up the problem since we can.

Thanks a lot for the PR!
I've released 2.2.1 with this fix - it'll be on central soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants