Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove arrow function causing this.resourcePath to be undefined #2

Merged
merged 1 commit into from
Mar 16, 2017

Conversation

Toilal
Copy link
Contributor

@Toilal Toilal commented Mar 16, 2017

Close #1

@ktsn
Copy link
Owner

ktsn commented Mar 16, 2017

Thanks!

@ktsn ktsn merged commit 8830bb4 into ktsn:master Mar 16, 2017
@Toilal
Copy link
Contributor Author

Toilal commented Mar 16, 2017

Thanks you too for the project.

I don't like .vue component files that much, and this plugin is really required to have a fast reload on development environment.

Can you perform a release soon with the fix ?

@Toilal
Copy link
Contributor Author

Toilal commented Mar 16, 2017

Also there's a duplicate project here : https://github.com/jshmrtn/vue-hot-loader. Maybe we could tell this guy to join your project ?

I think your module is more robust because it checks there's a default export on the component file.

@ktsn
Copy link
Owner

ktsn commented Mar 16, 2017

I've released v0.1.1 with this fix.

Well, not sure about the collaboration. I actually just create this library as a small experiment and probably won't develop it actively so much. But PRs always welcome.

@Toilal
Copy link
Contributor Author

Toilal commented Mar 16, 2017

Yes, I just found your other project vue-template-loader that seems to be a step beyond for what I need too :)

@Toilal Toilal deleted the feature/no-arrow-function branch March 17, 2017 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants