update/peer-dependencies #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
please bump the vue-class-component dependency, if possible it appears to be working just fine but I haven't run any extensive tests
ktsn
requested changes
Mar 15, 2019
package.json
Outdated
| @@ -64,6 +64,6 @@ | |||
| "peerDependencies": { | |||
| "vue": "^2.5.0", | |||
| "vuex": "^3.0.0", | |||
| "vue-class-component": "^6.0.0" | |||
| "vue-class-component": "^7.0.0" | |||
There was a problem hiding this comment.
Could you include ^6.0.0 because it should be compatible with both? So it will be ^6.0.0 || ^7.0.0
|
The current version is already ^6.0.0 and it throws yarn warnings if you
have 7 side by side.
…On Thu, 14 Mar 2019 at 23:30 katashin ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In package.json
<#48 (comment)>:
> @@ -64,6 +64,6 @@
"peerDependencies": {
"vue": "^2.5.0",
"vuex": "^3.0.0",
- "vue-class-component": "^6.0.0"
+ "vue-class-component": "^7.0.0"
Could you include ^6.0.0 because it should be compatible with both? So it
will be ^6.0.0 || ^7.0.0
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#48 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ASb5jM-vyS3DKMlxTW9plXC9nY-aeiuIks5vWwXCgaJpZM4b0vTs>
.
|
|
@oakromulo What do you mean by that? |
- retain support for `vue-class-component` *v6* alongside *v7* as a peer dependency
oakromulo
commented
Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please bump the vue-class-component dependency, if possible
it appears to be working just fine but I haven't run any formal tests