fix: Fix guess array element issue on type array of Object (#36)

package.json

@@ -19,7 +19,7 @@
   "license": "MIT",
   "dependencies": {
     "@types/validator": "^12.0.1",
-    "tinspector": "^2.2.9",
+    "tinspector": "^2.2.10",
     "tslib": "^1.10.0",
     "validator": "^12.1.0"
   },

src/visitor.ts

@@ -116,7 +116,10 @@ function objectVisitor(value: any, ast: ObjectNode, opt: VisitorOption): Result
 }
 
 function visitor(value: any, ast: SuperNode, opt: VisitorOption): Result {
-    if (value === undefined || value === null || value.constructor === ast.type || ast.type === Object) return { value }
+    if (value === undefined || value === null)
+        return { value }
+    if (value.constructor === ast.type || ast.type === Object)
+        return { value: ast.kind === "Array" && opt.guessArrayElement && !Array.isArray(value) ? [value] : value }
     return visitorMap[ast.kind](value, ast as any, opt)
 }
 

test/__snapshots__/converter-array.spec.ts.snap

@@ -0,0 +1,35 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`Array Converter Should convert array of Object as is 1`] = `
+Array [
+  Object {
+    "birthday": "2018-2-2",
+    "deceased": "ON",
+    "id": "200",
+    "name": "Mimi",
+  },
+  Object {
+    "birthday": "2018-2-2",
+    "deceased": "ON",
+    "id": "200",
+    "name": "Mimi",
+  },
+  Object {
+    "birthday": "2018-2-2",
+    "deceased": "ON",
+    "id": "200",
+    "name": "Mimi",
+  },
+]
+`;
+
+exports[`Guess Array Element Should work for array on nested Object without type override 1`] = `
+AnimalClass {
+  "tags": Array [
+    Object {
+      "id": "123",
+      "name": "lorem",
+    },
+  ],
+}
+`;

test/converter-array.spec.ts

@@ -32,6 +32,15 @@ describe("Array Converter", () => {
         ])
     })
 
+    it("Should convert array of Object as is", () => {
+        const result = convert([
+            { id: "200", name: "Mimi", deceased: "ON", birthday: "2018-2-2" },
+            { id: "200", name: "Mimi", deceased: "ON", birthday: "2018-2-2" },
+            { id: "200", name: "Mimi", deceased: "ON", birthday: "2018-2-2" }
+        ], { type: [Object] })
+        expect(result.value).toMatchSnapshot()
+    })
+
     it("Should convert nested array inside model", () => {
         @reflect.parameterProperties()
         class TagModel {
@@ -107,8 +116,34 @@ describe("Array Converter", () => {
         expect(result.issues).toEqual([{ path: "1.tags.1.id", messages: ["Unable to convert \"Hello\" into Number"] }])
     })
 
-    it("Should able to guess non array for single element as element if defined", () => {
+})
+
+describe("Guess Array Element", () => {
+    it("Should able to guess single value as Array based on type", () => {
         const b = convert("1234", { type: [Number], guessArrayElement: true })
         expect(b.value).toEqual([1234])
     })
+
+    it("Should work for array of Object", () => {
+        const b = convert("1234", { type: [Object], guessArrayElement: true })
+        expect(b.value).toEqual(["1234"])
+    })
+
+    it("Should work for array on nested Object without type override", () => {
+        @reflect.parameterProperties()
+        class TagModel {
+            constructor(
+                public id: number,
+                public name: string,
+            ) { }
+        }
+        @reflect.parameterProperties()
+        class AnimalClass {
+            constructor(
+                public tags: TagModel[] // <-- no type override
+            ) { }
+        }
+        const b = convert({ tags: { id: "123", name: "lorem" } }, { type: AnimalClass, guessArrayElement: true })
+        expect(b.value).toMatchSnapshot()
+    })
 })