Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disappeared from stackage nightlies? #6

Closed
mstksg opened this issue Jun 2, 2016 · 4 comments
Closed

Disappeared from stackage nightlies? #6

mstksg opened this issue Jun 2, 2016 · 4 comments

Comments

@mstksg
Copy link

mstksg commented Jun 2, 2016

Hi,

Thank you for the great package :) I was wondering if this package was being specifically withheld from the new stackage nightlies which are running on GHC 8.0? I seem to be able to build this package fine with the latest nightly:

$ git clone git@github.com:ku-fpg/data-reify.git
$ cd data-reify
$ stack init --resolver nightly-2016-06-02
$ stack install

Is it just that package just taken off automatically with the new update, and has not been manually added back on yet? Or is there an intentional reason I'm missing?

Thanks!

@RyanGlScott
Copy link
Member

RyanGlScott commented Jun 2, 2016

The reason is even simpler. Currently, there are no @ku-fpg packages explicitly listed in the build plan for Stackage, but a couple of them were automatically brought in to satisfy the dependencies of other packages (for example, diagrams-canvas brings in blank-canvas and kansas-comet). I suspect a package that depends ondata-reify was blocked from Stackage recently due to the GHC 8 release, leading to data-reify also being dropped.

To prevent this thing in the future, I could explicitly add some @ku-fpg packages to the build-constraints.yaml file for Stackage, but before I do that, I want to get @andygill's permission, because if we add these libraries to Stackage and they break in the future, it'll send him e-mail notifications :)

@andygill
Copy link
Member

andygill commented Jun 5, 2016

Just tell me how to help, @RyanGlScott, and we'll set things up.

@RyanGlScott
Copy link
Member

RyanGlScott commented Jun 5, 2016

You can add your packages to Stackage by making a pull request against fpco/stackage which modifies build-constraints.yaml accordingly. For example, if you applied this change:

diff --git a/build-constraints.yaml b/build-constraints.yaml
index 3fc560c..4d1d09a 100644
--- a/build-constraints.yaml
+++ b/build-constraints.yaml
@@ -315,6 +315,12 @@ packages:
         - scotty
         - wai-middleware-static

+    "Andy Gill <your-email-here.example>":
+        - blank-canvas
+        - data-reify
+        - dotgen
+        - kansas-comet
+
     "Simon Hengel <sol@typeful.net>":
         - hspec
         - hspec-wai
@@ -3000,6 +3006,7 @@ github-users:
         - RyanGlScott
         - xich
     ku-fpg:
+        - andygill
         - RyanGlScott
     haskell-compat:
         - RyanGlScott

Then the blank-canvas, kansas-comet, dotgen, and data-reify packages will be explicitly added to Stackage as standalone libraries. Adding your username to the ku-fpg usermap will also make it so that if one of those packages breaks, it'll notify you. (This part is optional. Currently, it just notifies me :) )

@RyanGlScott
Copy link
Member

I added myself as the Stackage maintainer for this package a while ago (see commercialhaskell/stackage@ea928b0bc), so this should no longer be an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants