Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deletion of updated files #24

Closed
motine opened this issue May 1, 2012 · 1 comment
Closed

Deletion of updated files #24

motine opened this issue May 1, 2012 · 1 comment

Comments

@motine
Copy link

motine commented May 1, 2012

hi,

I was just looking through the code and was wondering about the following case:
slave A removes a file while slave B updates the file.
In this case I would guess that a convenient way to procede would be to update the file and not delete it.
From what I saw, the script does it the other way around. Is this the desired outcome?

Thanks
Tom

@ku1ik
Copy link
Owner

ku1ik commented May 1, 2012

Hi,

Yeah, this is one of these cases where it is hard to define correct behavior. In this case also it's hard to say who "is right", A or B. For safety it would be better to keep updated file because it may include new important content. Unfortunately rsync doesn't keep any log with deletion/update times so it can't tell if the file that was deleted on A (and thus removed from "master" store) should be restored from A's copy. Adding workaround for this case would require a lot of code (and almost implementing light scm) and I'm not planning to do this. If you feel it's crucial you can fork and try implementing such an improvement. If it appears to be light solution than I will happily merge it.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants