bitpocket without GNU coreutils (like on macOS) #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 23, 2017 20:14
The biggest change is in the usage of the `sed` utility, which seems not to handle \s and \S like the GNU counterpart.
The shell normally inherits the environment, but in this case we would use `env` to find the location of bash rather than specifying the absolute path.
|
This has been merged into the master branch and released in https://github.com/sickill/bitpocket/releases/tag/v0.2. FreeBSD still does not work, so the second commit was discarded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bitpocket seems to have a history of issues on macOS (BSD unix). This patch is an attempt to clear the water and fully support it. With it, bitpocket fully passes the
raketests on macOS 10.12 (Sierra).The biggest change is in the usage of the
sedutility, which seems not to handle \s and \S like the GNU counterpart.