Add support for REMOTE_BACKUPS #64
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greezybacon
force-pushed
the
feature/remote-backups
branch
2 times, most recently
from
fd99bab
to
ec2ff68
Compare
Use `rsync` to do the backing up rsync has a --backup option which will accomplish what the backup_inline function is accomplishing. However, it will add the ability to do remote backups without doing remote shell magic. Coincidently, this removes the parallel rsync used to do the pull(), which may reduce the CPU and disk overhead slightly. This allows the remote host to cooperate with the PUSH process and create backups on the remote host itself, for files which will be overwritten by the PUSH. Remote backups is an optional feature, disabled by default, and can be enabled with the REMOTE_BACKUPS option in the configuration file.
This re-introduces the behavior from ac0622c which in the backup_inline function would detect if files were removed remotely before deleting locally. This is necessary for long-running syncs to behave properly as files created locally after the sync was started should be protected from removal. It is implemented here using rsync filter rules rather than the grep expression as before.
greezybacon
force-pushed
the
feature/remote-backups
branch
from
3efc293
to
07d89ab
Compare
This is similar to the code to protect locally-created files in parallel with a long-running sync. Since files which show up after the sync takes a directory snapshot are not protected, they could be deleted. This protects all the remote files except for the locally-deleted files. So, the only files removed in the push are the ones which were removed locally since the previous sync.
Filter rules with [ * ? characters in them are considered patterns or wildcards. However, the interpretation of bitpocket is that they should be considered exact file names. This patch properly escapes the characters in the file names in the analysis phase.
Also be more consistent. Use the exact same expressions and replacements in all places where it used.
greezybacon
force-pushed
the
feature/remote-backups
branch
from
c0875a3
to
b55c1dc
Compare
|
This has been merged into the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the remote host to cooperate with the PUSH process and create backups on the remote host itself, for files which will be overwritten by the PUSH. Backups are already created in the pull process. This adds the same feature on the remote server.
It works by copying
bitpocketto the remote server and running it. Then it sends the file names it wants to push to the bitpocket process on the remote server. Then the remote server uses thebackup_inlinefunction to handle creating backups exactly the same as what happens in the pull process.Addreses #53
Outstanding
rmdirerror when cleaning the (non-)empty backup folder