Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added terminal-notifier (for notification center) and github #30

Closed
wants to merge 3 commits into from

Conversation

DAddYE
Copy link

@DAddYE DAddYE commented Sep 19, 2012

Hi!

thanks for this awesome script.

Since on Mountain Lion we have the notification center with terminal-notifier is quite easy to use it.

I also added (only for terminal-notifier) an open action, so if the repo is hosted on github when you click on the notification banner you will be redirected on the github project page, showing you the diff, the new branch or tag.

I'm not a bash expert so, if you accept this pull request, you should review my changes.

Thanks for your time!

* Added Mountain Lion notification center
* If the repo is hosted on github we will open it, only
terminal-notifier, atm.
@ku1ik
Copy link
Owner

ku1ik commented Feb 24, 2015

This tool is git hosting agnostic and I like it to be like that. Thanks anyway!

@ku1ik ku1ik closed this Feb 24, 2015
@morgant
Copy link

morgant commented Feb 24, 2015

I like that git-dude is hosting agnostic, but the Notification Center functionality sounds useful. Worth opening an issue for adding such support using terminal-notifier?

@ku1ik
Copy link
Owner

ku1ik commented Feb 24, 2015

@morgant yeah, sure. I'm always open to add new notification backends. This one mixed terminal-notifier and github but I'm happy to accept a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants