-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minimum version of ruby supported making Github Action rubocop crash + version missing on rubygems #106
Comments
Duplicates #95. Thanks for reporting! |
@olleolleolle Not dupe. #95 is an issue from 2019 when there was only rainbow 3.0.0 that asked to create a new version 3.1.0 with ruby 2.3 as min. In the meantime (august 2020) rainbow 3.1.0 was released (git tag). My issue #106 is asking 2 things:
which is different from creating a 3.1.0 version (which is already done) so you could close #95 and re-open this one. |
The problem of access remains the same, though. As soon as that's cleared up, releases can be cut etc. |
I'll try this workaround rubocop/rubocop#6398 (comment) in the meantime |
try suggested workaround from rubocop/rubocop#6398 for ku1ik/rainbow#106
try suggested workaround from rubocop/rubocop#6398 for ku1ik/rainbow#106
try suggested workaround from rubocop/rubocop#6398 for ku1ik/rainbow#106
try suggested workaround from rubocop/rubocop#6398 for ku1ik/rainbow#106
try suggested workaround from rubocop/rubocop#6398 for ku1ik/rainbow#106
On my computer
bundle exec rubocop
gives no offenses or error (ruby 2.7).But on the CI (Github Action, image ruby 2.6) I get an error because ruby 2.1 is not supported by rubocop.
Rubocop detects ruby 2.1 in TargetRubyVersion of Rainbow rubocop file. It seems to be because I use the
paint
gems that requiresrainbow 3.0.0
which is the last version available on rubygems.Seems you know requires ruby 2.3 in git tag 3.1.0 but it will still crash since rubocops says:
So could you requires at least ruby 2.4 in the rubocop file (and gemspec for no mismatch or disable the cop that check that), I don't really understand why rubocops on the CI is running on all the sub-dependencies instead of just my code, my best guess is that I requires paint here that itself requires rainbow.
So please:
The text was updated successfully, but these errors were encountered: