Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimum version of ruby supported making Github Action rubocop crash + version missing on rubygems #106

Closed
noraj opened this issue Mar 12, 2021 · 5 comments

Comments

@noraj
Copy link

noraj commented Mar 12, 2021

On my computer bundle exec rubocop gives no offenses or error (ruby 2.7).

But on the CI (Github Action, image ruby 2.6) I get an error because ruby 2.1 is not supported by rubocop.
Rubocop detects ruby 2.1 in TargetRubyVersion of Rainbow rubocop file. It seems to be because I use the paint gems that requires rainbow 3.0.0 which is the last version available on rubygems.

Seems you know requires ruby 2.3 in git tag 3.1.0 but it will still crash since rubocops says:

Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

So could you requires at least ruby 2.4 in the rubocop file (and gemspec for no mismatch or disable the cop that check that), I don't really understand why rubocops on the CI is running on all the sub-dependencies instead of just my code, my best guess is that I requires paint here that itself requires rainbow.

So please:

  1. Release 3.1.0 on rubygems
  2. Make a new 3.2.0 with ruby 2.4 as min version and release it on rubygems
@olleolleolle
Copy link
Collaborator

Duplicates #95.

Thanks for reporting!

@noraj
Copy link
Author

noraj commented Mar 12, 2021

@olleolleolle Not dupe. #95 is an issue from 2019 when there was only rainbow 3.0.0 that asked to create a new version 3.1.0 with ruby 2.3 as min. In the meantime (august 2020) rainbow 3.1.0 was released (git tag). My issue #106 is asking 2 things:

  • Release 3.1.0 on rubygems
  • Make a new 3.2.0 with ruby 2.4 as min version and release it on rubygems

which is different from creating a 3.1.0 version (which is already done) so you could close #95 and re-open this one.

@olleolleolle
Copy link
Collaborator

The problem of access remains the same, though. As soon as that's cleared up, releases can be cut etc.

@noraj
Copy link
Author

noraj commented Apr 15, 2021

Please Github CI of thousands of tools are failing because of rainbow 3.0.0 min ruby requirements.

image

@noraj
Copy link
Author

noraj commented Jul 9, 2021

I'll try this workaround rubocop/rubocop#6398 (comment) in the meantime

noraj added a commit to noraj/ctf-party that referenced this issue Jul 9, 2021
noraj added a commit to noraj/haiti that referenced this issue Jul 12, 2021
noraj added a commit to noraj/vrt-cli that referenced this issue Jul 19, 2021
noraj added a commit to sec-it/pass-station that referenced this issue Jul 19, 2021
noraj added a commit to sec-it/tls-map that referenced this issue Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants