Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update .rubocop.yml #88

Merged
merged 1 commit into from
Feb 24, 2019
Merged

Update .rubocop.yml #88

merged 1 commit into from
Feb 24, 2019

Conversation

bazay
Copy link
Contributor

@bazay bazay commented Nov 26, 2018

In reference to issue: #87

@bazay
Update .rubocop.yml
91719f7 
In reference to issue: ku1ik#87
bazay
bazay commented Nov 26, 2018
View reviewed changes
.rubocop.yml
@@ -3,7 +3,6 @@ inherit_from: .rubocop_todo.yml
AllCops:
DisplayCopNames: true
DisplayStyleGuide: true
TargetRubyVersion: "2.1"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really necessary?

@pvdb
Copy link

pvdb commented Feb 24, 2019

Can we please get this PR merged in? The issue reported by @bazay is causing the TravisCI build for my rainbow-dependent gem to fail:

Running RuboCop...
Error: Unsupported Ruby version 2.1 found in `TargetRubyVersion` parameter (in vendor/bundle/ruby/2.3.0/gems/rainbow-3.0.0/.rubocop.yml). 2.1-compatible analysis was dropped after version 0.58.
Supported versions: 2.2, 2.3, 2.4, 2.5, 2.6
RuboCop failed!

olleolleolle
olleolleolle approved these changes Feb 24, 2019
View reviewed changes
Copy link
Collaborator

@olleolleolle olleolleolle left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.1 if out of support and also removed from RuboCop - no reason to keep this in.

Thanks for changing the thing - and thanks for reminding about this change!

Kudos to you both!

@olleolleolle olleolleolle merged commit 3501a1e into ku1ik:master Feb 24, 2019
@cllns cllns mentioned this pull request Jul 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bazay @pvdb @olleolleolle